tonyespy
commented
4 years ago Approved. Just as a reminder, this is the first of a few steps to get to a usable node with the expected label.
Thanks @MightyNerdEric. @ernestojeda pointed me to the instructions in the associated issue, so after this is merged and the image created, my next step will be to submit a PR that adds a new cfg to jenkins-config/clouds/openstack/Primary.
Next I'll need to update the actual snap build script, then change the amd64 build job to reference this new cfg. I'll definitely let you know if I have any issues, and thanks in advance for the help!
ernestojeda
Add a new amd64 Ubuntu 18.04 platform for snap builds. This is the first step required to resolve issue #619.
Signed-off-by: Tony Espy espy@canonical.com
PR Checklist
Please check if your PR fulfills the following requirements:
[x] The commit message follows our guidelines: https://github.com/edgexfoundry/ci-management/blob/master/.github/CONTRIBUTING.md
[NA] Tests for the changes have been added (for bug fixes / features)
[ ] Added labels
PR Type
What kind of change does this PR introduce?
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:
Issue Number: 619
Sandbox Testing
Test Links :
Are there any new imports or modules? If so, what are they used for and why?
No
Are there any specific instructions or things that should be known prior to reviewing?
This is the first step required to resolve issue #619. Once this lands, a new image will be produced and the next PR will add a new config which references the new image. The last step involves modifying the amd64 snap build job to reference this new platform.
Other information