Build Error: CMake Error at CMakeLists.txt

[M0hanrajp]

🐞 Bug Report

Affected Services [REQUIRED]

Issue was found during build process of https://github.com/edgexfoundry/device-bacnet-c

Is this a regression?

Not sure, not tried the previous versions of the build.

Description and Minimal Reproduction [REQUIRED]

• Clone the 3.1.0 version of this repo.
• execute ./scripts/build.sh to build the application.

More info will be found in discussion: Not able to build device-bacnet-c, CMake Error at CMakeLists.txt #302

🔥 Exception or Error

• When I clone the service and execute ./scripts/build.sh the following error is observed:

  ...
  ...
  -- Found IOT: /opt/iotech/iot/1.5/lib/libiot.so
  -- /opt/iotech/iot/1.5/include
  CMake Error at CMakeLists.txt:61 (FILE):
  FILE STRINGS file
  "/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/src/c/../../VERSION"
  cannot be read.
  # Please find more error info in discussion #302, link posted above

🌍 Your Environment

Deployment Environment:Ubuntu 22.04

EdgeX Version [REQUIRED]:3.1.1-Napa

Anything else relevant?

Yes, by following the below process the build was successful but I'm not sure if the build succeeds.

• Try cloning the service, cd to directory, execute make build instead of scripts/build.sh
• the following logs are observed:

  
  ~/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0$ make build
  fatal: not a git repository (or any of the parent directories): .git
  scripts/build.sh

• readlink -f scripts/build.sh
• dirname /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/scripts/build.sh
• dirname /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/scripts
• ROOT=/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0
• echo /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0 /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0
• cd /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0
• [ ! -f /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/lib/ip/libbacnet.a ]
• [ ! -f /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/lib/mstp/libbacnet.a ]
• mkdir -p /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-ip
• cd /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-ip
• cmake -DDATALINK:STRING=BACDL_BIP=1 -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_BUILD_TYPE=Release /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/src/c -- /opt/iotech/iot/1.5/include -- Configuring done -- Generating done -- Build files have been written to: /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-ip
• make
• tee release.log make[1]: Entering directory '/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-ip' make[2]: Entering directory '/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-ip' make[3]: Entering directory '/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-ip' make[3]: Leaving directory '/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-ip' make[3]: Entering directory '/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-ip' [ 11%] Building C object CMakeFiles/bacnet_objects.dir/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/bacnet-stack/demo/object/device-client.c.o [ 22%] Linking C static library libbacnet_objects.a make[3]: Leaving directory '/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-ip' [ 22%] Built target bacnet_objects make[3]: Entering directory '/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-ip' make[3]: Leaving directory '/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-ip' make[3]: Entering directory '/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-ip' [ 33%] Building C object CMakeFiles/device-bacnet-c.dir/main.c.o [ 44%] Building C object CMakeFiles/device-bacnet-c.dir/address_entry.c.o [ 55%] Building C object CMakeFiles/device-bacnet-c.dir/address_instance_map.c.o [ 66%] Building C object CMakeFiles/device-bacnet-c.dir/device_condition_map.c.o [ 77%] Building C object CMakeFiles/device-bacnet-c.dir/driver.c.o [ 88%] Building C object CMakeFiles/device-bacnet-c.dir/return_data.c.o [100%] Linking C executable device-bacnet-c make[3]: Leaving directory '/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-ip' [100%] Built target device-bacnet-c make[2]: Leaving directory '/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-ip' make[1]: Leaving directory '/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-ip'
• mkdir -p /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-mstp
• cd /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-mstp
• cmake -DDATALINK:STRING=BACDL_MSTP=1 -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_BUILD_TYPE=Release /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/src/c -- The C compiler identification is GNU 11.4.0 -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working C compiler: /usr/bin/cc - skipped -- Detecting C compile features -- Detecting C compile features - done -- Looking for pthread.h -- Looking for pthread.h - found -- Performing Test CMAKE_HAVE_LIBC_PTHREAD -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success -- Found Threads: TRUE -- Found IOT: /opt/iotech/iot/1.5/lib/libiot.so -- /opt/iotech/iot/1.5/include -- Configuring done -- Generating done -- Build files have been written to: /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-mstp
• make+ tee release.log make[1]: Entering directory '/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-mstp' make[2]: Entering directory '/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-mstp' make[3]: Entering directory '/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-mstp' make[3]: Leaving directory '/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-mstp' make[3]: Entering directory '/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-mstp' [ 11%] Building C object CMakeFiles/bacnet_objects.dir/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/bacnet-stack/demo/object/device-client.c.o [ 22%] Linking C static library libbacnet_objects.a make[3]: Leaving directory '/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-mstp' [ 22%] Built target bacnet_objects make[3]: Entering directory '/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-mstp' make[3]: Leaving directory '/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-mstp' make[3]: Entering directory '/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-mstp' [ 33%] Building C object CMakeFiles/device-bacnet-c.dir/main.c.o [ 44%] Building C object CMakeFiles/device-bacnet-c.dir/address_entry.c.o [ 55%] Building C object CMakeFiles/device-bacnet-c.dir/address_instance_map.c.o [ 66%] Building C object CMakeFiles/device-bacnet-c.dir/device_condition_map.c.o [ 77%] Building C object CMakeFiles/device-bacnet-c.dir/driver.c.o [ 88%] Building C object CMakeFiles/device-bacnet-c.dir/return_data.c.o [100%] Linking C executable device-bacnet-c make[3]: Leaving directory '/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-mstp' [100%] Built target device-bacnet-c make[2]: Leaving directory '/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-mstp' make[1]: Leaving directory '/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-mstp'

• Now again execute scripts/build.sh in the same directory
• the following logs are observed:

  
  ~/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0$ ./scripts/build.sh

• readlink -f ./scripts/build.sh
• dirname /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/scripts/build.sh
• dirname /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/scripts
• ROOT=/home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0
• echo /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0 /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0
• cd /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0
• [ ! -f /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/lib/ip/libbacnet.a ]
• [ ! -f /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/lib/mstp/libbacnet.a ]
• mkdir -p /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-ip
• cd /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-ip
• cmake -DDATALINK:STRING=BACDL_BIP=1 -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_BUILD_TYPE=Release /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/src/c -- /opt/iotech/iot/1.5/include -- Configuring done -- Generating done -- Build files have been written to: /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-ip
• make
• tee release.log Consolidate compiler generated dependencies of target bacnet_objects [ 22%] Built target bacnet_objects Consolidate compiler generated dependencies of target device-bacnet-c [100%] Built target device-bacnet-c
• mkdir -p /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-mstp
• cd /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-mstp
• cmake -DDATALINK:STRING=BACDL_MSTP=1 -DCMAKE_EXPORT_COMPILE_COMMANDS=ON -DCMAKE_BUILD_TYPE=Release /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/src/c -- /opt/iotech/iot/1.5/include -- Configuring done -- Generating done -- Build files have been written to: /home/mpunix/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-mstp
• make
• tee release.log Consolidate compiler generated dependencies of target bacnet_objects [ 22%] Built target bacnet_objects Consolidate compiler generated dependencies of target device-bacnet-c [100%] Built target device-bacnet-c

[M0hanrajp]

But when executing make build and scripts/build.sh both, the following error is observed while running bacnet ip & mstp device service:

~/edgex-foundry/edgex-device-sdk-c/device-bacnet-c-3.1.0/build/release/device-bacnet-ip$ ./device-bacnet-c
level=ERROR ts=2024-08-14T14:54:31Z app=device-bacnet-ip msg="devsdk_service_new: no version specified"
Error: 7: No Device version was specified

Please help on this !

[M0hanrajp]

If the make build and scripts/build.sh process seem to build correctly should we change the execution process ?

[M0hanrajp]

Fixed using solution at discussion 302