Closed kb2ma closed 3 years ago
I just pushed some fixups, but I've got a better idea for the VERSION implementation. I'll force push later today. I'll let you know when ready for review.
Fixups ready for review, @iain-anderson. I'm happy to squash down to a single commit when you're done if that's customary.
I have squashed manually in the past and was not aware of the squash-merge option. Thanks for review and the suggestion.
Signed-off-by: Ken Bannister kb2ma@runbox.com
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-examples/blob/master/.github/CONTRIBUTING.md.
What is the current behavior?
new repository
Issue Number:
n/a
What is the new behavior?
Initial commit taken from from kb2ma/device-coap-c-pre-holding. See README.md for details.
Does this PR introduce a breaking change?
New Imports
n/a
Specific Instructions
See inline comments for potential issues
Other information