edgexfoundry / device-coap-c

EdgeX device service for CoAP-based REST protocol
Apache License 2.0
3 stars 18 forks source link

Inconsistent docker image names between Makefile and CI #35

Closed bnevis-i closed 2 years ago

bnevis-i commented 2 years ago

In the Makefile, this project builds a docker-device-coap-c container.

device_coap:
        docker build \
            -f scripts/Dockerfile.alpine \
            --label "git_sha=$(GIT_SHA)" \
            -t edgexfoundry/docker-device-coap-c:${GIT_SHA} \
            -t edgexfoundry/docker-device-coap-c:${VERSION}-dev \
            .

But the Jenkinsfile builds the "device-coap" container. https://github.com/edgexfoundry/device-coap-c/blob/main/Jenkinsfile

We should update the Makefile to use the new standard container name.

lenny-goodell commented 2 years ago

@bnevis-i , good catch. Apparently a miss when we dropped the docker- and -c from the names.

iain-anderson commented 2 years ago

closed #37