edgexfoundry / device-onvif-camera

Owner: Device WG
Apache License 2.0
29 stars 37 forks source link

fix: [WIP BUG] Add ProfilesDir & DevicesDir to local config #309

Closed lenny-goodell closed 1 year ago

lenny-goodell commented 1 year ago

This is so that the values can be overriden with Envs

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

Run non-secure EdgeX stack and stop docker version of service if running Run make build Edit config to uncomment Host values for hybrid mode Run service locally with -cp -o options Verify profile and devices files loaded

New Dependency Instructions (If applicable)

codecov-commenter commented 1 year ago

Codecov Report

Merging #309 (6bdb430) into main (7c14cf8) will not change coverage. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #309   +/-   ##
=======================================
  Coverage   33.42%   33.42%           
=======================================
  Files          18       18           
  Lines        1798     1798           
=======================================
  Hits          601      601           
  Misses       1131     1131           
  Partials       66       66           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.