edgexfoundry / device-onvif-camera

Owner: Device WG
Apache License 2.0
29 stars 37 forks source link

fix: update secret url to v3 in scripts #328

Closed ajcasagrande closed 1 year ago

ajcasagrande commented 1 year ago

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

Run latest edgex-compose with latest onvif service. Run ./bin/map-credentials.sh. Expect 200 success.

New Dependency Instructions (If applicable)

codecov-commenter commented 1 year ago

Codecov Report

Merging #328 (1572db2) into main (00bdd2c) will not change coverage. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #328   +/-   ##
=======================================
  Coverage   33.38%   33.38%           
=======================================
  Files          18       18           
  Lines        1800     1800           
=======================================
  Hits          601      601           
  Misses       1133     1133           
  Partials       66       66           
vyshali-chitikeshi commented 1 year ago

Validation looks good with latest code of edgex from main branch.