edgexfoundry / device-onvif-camera

Owner: Device WG
Apache License 2.0
29 stars 37 forks source link

feat: implement secret change support, refactor cred mgmt #333

Closed ajcasagrande closed 1 year ago

ajcasagrande commented 1 year ago

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

New Dependency Instructions (If applicable)

codecov-commenter commented 1 year ago

Codecov Report

Merging #333 (368d8b8) into main (ca50ff0) will increase coverage by 0.56%. The diff coverage is 17.26%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
+ Coverage   33.38%   33.95%   +0.56%     
==========================================
  Files          18       18              
  Lines        1800     1832      +32     
==========================================
+ Hits          601      622      +21     
- Misses       1133     1143      +10     
- Partials       66       67       +1     
Impacted Files Coverage Δ
internal/driver/basenotificationresthandler.go 0.00% <0.00%> (ø)
internal/driver/checkstatuses.go 37.61% <0.00%> (-2.20%) :arrow_down:
internal/driver/onvifclient.go 19.66% <0.00%> (-3.99%) :arrow_down:
internal/driver/onvifdiscovery.go 27.60% <0.00%> (-0.51%) :arrow_down:
internal/driver/pullpointsubscriber.go 0.00% <0.00%> (ø)
internal/driver/driver.go 19.42% <29.72%> (+5.32%) :arrow_up:
internal/driver/credentials.go 75.75% <50.00%> (-24.25%) :arrow_down:
internal/driver/macmapper.go 86.56% <50.00%> (-2.50%) :arrow_down: