edgexfoundry / device-onvif-camera

Owner: Device WG
Apache License 2.0
29 stars 37 forks source link

feat: implement driver Start command #343

Closed ajcasagrande closed 1 year ago

ajcasagrande commented 1 year ago

It seems like GitHub wants to do some funky things with the change detection because of my reordering of functions. Here is a breakdown of the changes:

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

New Dependency Instructions (If applicable)

Fixes #308

codecov-commenter commented 1 year ago

Codecov Report

Merging #343 (c65c0a2) into main (3c68e39) will decrease coverage by 0.08%. The diff coverage is 20.40%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
- Coverage   33.25%   33.18%   -0.08%     
==========================================
  Files          18       19       +1     
  Lines        1798     1802       +4     
==========================================
  Hits          598      598              
- Misses       1134     1138       +4     
  Partials       66       66              
Impacted Files Coverage Δ
internal/driver/driver.go 12.13% <4.28%> (-4.76%) :arrow_down:
internal/driver/util.go 60.71% <60.71%> (ø)