Closed presatish closed 1 year ago
Merging #347 (2486354) into main (b5d61d0) will not change coverage. The diff coverage is
n/a
.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@ Coverage Diff @@
## main #347 +/- ##
=======================================
Coverage 33.07% 33.07%
=======================================
Files 19 19
Lines 1808 1808
=======================================
Hits 598 598
Misses 1144 1144
Partials 66 66
I defer to @ajcasagrande & @ChristianDarr-personal on this one.
You do need to fix the commit message and DCO issues
@presatish BTW, the commit message should be a refactor!:
not a fix:
, this is not a bug, but a tech debt and it is a BREAKING CHNAGE. Please update accordingly.
BREAKING CHANGE: Making Edgex command names consistent by removing
GET
andSET
keywords.PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
make test make docker /compose-builder$ git checkout main /compose-builder$ make pull /compose-builder$ make gen no-secty ds-onvif-camera Replace onvif service docker image in docker-compose.yml with your latest image created using make docker from the previous step /compose-builder$ make up /bin/configure-subnets.sh without error /bin/map-credentials.sh without error Onvif devices should be registered in Edgex Get the updated postman collection and env from the doc folder, update the env with the names of onvif cameras and run the collection without error.
New Dependency Instructions (If applicable)