Closed ajcasagrande closed 1 year ago
Merging #355 (74a069d) into main (19aea07) will increase coverage by
0.67%
. The diff coverage is89.18%
.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@ Coverage Diff @@
## main #355 +/- ##
==========================================
+ Coverage 33.07% 33.75% +0.67%
==========================================
Files 19 19
Lines 1808 1822 +14
==========================================
+ Hits 598 615 +17
+ Misses 1144 1141 -3
Partials 66 66
Impacted Files | Coverage Δ | |
---|---|---|
internal/driver/onvifclient.go | 21.50% <0.00%> (ø) |
|
internal/driver/onvifdiscovery.go | 27.98% <0.00%> (+0.37%) |
:arrow_up: |
internal/driver/driver.go | 14.63% <96.00%> (+2.76%) |
:arrow_up: |
internal/driver/checkstatuses.go | 33.66% <100.00%> (+2.03%) |
:arrow_up: |
internal/driver/util.go | 66.66% <100.00%> (+5.95%) |
:arrow_up: |
Validation looks good. Verified that device status and last seen updated correctly. Verified using different check status interval settings.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
New Dependency Instructions (If applicable)