Closed presatish closed 1 year ago
Validation looks good. Tested without any profile token input and it generated snapshot with default/random profile. Verified that it does not generate snapshot with invalid profile token or invalid json value. Also verified that it generates snapshot for specific valid profile token.
BREAKING CHANGE: Making Snapshot command consistent by requiring the request to have profile token to provide snapshot response.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
make test make docker /compose-builder$ git checkout main /compose-builder$ make pull /compose-builder$ make gen no-secty ds-onvif-camera Replace onvif service docker image in docker-compose.yml with your latest image created using make docker from the previous step /compose-builder$ make up /bin/configure-subnets.sh without error /bin/map-credentials.sh without error Onvif devices should be registered in Edgex Get the updated postman collection and env from the doc folder, update the env with the names of onvif cameras and execute
Snapshot
command with different profiles or no profiles and test.New Dependency Instructions (If applicable)