refactor!: prefix some commands with onvif service name and add SnapshotUri

ajcasagrande commented 1 year ago

BREAKING CHANGE: Changed the name of many device commands to include a prefix of the onvif service they belong to. For example Status becomes PTZStatus, Profiles becomes MediaProfiles, etc.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[X] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?) n/a
[ ] TODO I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[ ] TODO I have opened a PR for the related docs change (if not, why?)

Testing Instructions

Make sure to clean edgex

Build and run latest edgex main and this branch of device-onvif-camera
Import the device-onvif-camera postman collection
Import the postman env file if not done already
Update postman env with your camera's values
Run the postman collection
Verify commands work as they did before

New Dependency Instructions (If applicable)

codecov-commenter commented 1 year ago

Codecov Report

Merging #357 (5f628de) into main (8f1cbae) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #357   +/-   ##
=======================================
  Coverage   34.09%   34.09%           
=======================================
  Files          19       19           
  Lines        1804     1804           
=======================================
  Hits          615      615           
  Misses       1123     1123           
  Partials       66       66

vyshali-chitikeshi commented 1 year ago

Executed several updated api's and they all seems to be working correctly. Validation perspective updating api names looks good, however all api execution will be done as part of release validation.

edgexfoundry / device-onvif-camera