edgexfoundry / device-onvif-camera

Owner: Device WG
Apache License 2.0
29 stars 37 forks source link

docs: add operationId, and do not remove schemas for Get commands #361

Closed ajcasagrande closed 1 year ago

ajcasagrande commented 1 year ago

Fixes #360

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

New Dependency Instructions (If applicable)

ajcasagrande commented 1 year ago

Currently failing openapi schema validation due to PullPointSubscription and BaseNotificationSubscription both using the same internal function name

UPDATE: Fixed.

codecov-commenter commented 1 year ago

Codecov Report

Merging #361 (a9f8de8) into main (c4faddb) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #361   +/-   ##
=======================================
  Coverage   34.09%   34.09%           
=======================================
  Files          19       19           
  Lines        1804     1804           
=======================================
  Hits          615      615           
  Misses       1123     1123           
  Partials       66       66           
ajcasagrande commented 1 year ago

Schema is messed up for both get and set network configuration

@ChristianDarr-personal Thanks, I will take a look. That command is an EdgeX macro command, so we may have to add a special case to handle it (or just tweak the sidecar yaml).