feat: replace gorilla/mux with labstack/echo

FelixTing commented 1 year ago

closes: #378

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

[x] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[x] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?)
[x] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[ ] I have opened a PR for the related docs change (if not, why?)

Testing Instructions

Run make docker to build the image From the latest compose-builder run make run no-secty device-dev ds-onvif-camera Set the log level of device-onvif-camera to DEBUG Verify the device-onvif-camera service bootstraps successfully and contains the following log message:

level=INFO ts=2023-08-28T04:27:18.179454Z app=device-onvif-camera source=basenotificationresthandler.go:53 msg="Route /api/v3/onvifevent/:deviceName/:resourceName added."

Send an ONVIF notification by executing the following command:

curl -X POST localhost:59984/api/v3/onvifevent/test/test

Verify the log contains the following message:

level=DEBUG ts=2023-08-28T04:27:21.803792Z app=device-onvif-camera source=basenotificationresthandler.go:62 msg="Received POST for Device=test Resource=test"

New Dependency Instructions (If applicable)

codecov-commenter commented 1 year ago

Codecov Report

Merging #379 (3f9311d) into main (ed280a7) will increase coverage by 0.09%. The diff coverage is 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
+ Coverage   34.09%   34.18%   +0.09%     
==========================================
  Files          19       19              
  Lines        1804     1799       -5     
==========================================
  Hits          615      615              
+ Misses       1123     1118       -5     
  Partials       66       66

Files Changed	Coverage Δ
internal/driver/basenotificationresthandler.go	`0.00% <0.00%> (ø)`

lenny-goodell commented 1 year ago

@FelixTing , this is not a breaking change since changing the signature of processAsyncRequest does not impact the use of this service. I.e. internal changes like this are not Breaking Changes. Please update the commit message and PR description to remove the Breaking Change details.

FelixTing commented 12 months ago

Updated copyright. @presatish Thank you for testing.

edgexfoundry / device-onvif-camera