Closed FelixTing closed 12 months ago
Merging #379 (3f9311d) into main (ed280a7) will increase coverage by
0.09%
. The diff coverage is0.00%
.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@ Coverage Diff @@
## main #379 +/- ##
==========================================
+ Coverage 34.09% 34.18% +0.09%
==========================================
Files 19 19
Lines 1804 1799 -5
==========================================
Hits 615 615
+ Misses 1123 1118 -5
Partials 66 66
Files Changed | Coverage Δ | |
---|---|---|
internal/driver/basenotificationresthandler.go | 0.00% <0.00%> (ø) |
@FelixTing , this is not a breaking change since changing the signature of processAsyncRequest does not impact the use of this service. I.e. internal changes like this are not Breaking Changes. Please update the commit message and PR description to remove the Breaking Change details.
Updated copyright. @presatish Thank you for testing.
closes: #378
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
Run make docker to build the image From the latest compose-builder run
make run no-secty device-dev ds-onvif-camera
Set the log level of device-onvif-camera toDEBUG
Verify the device-onvif-camera service bootstraps successfully and contains the following log message:Send an ONVIF notification by executing the following command:
Verify the log contains the following message:
New Dependency Instructions (If applicable)