edgexfoundry / device-onvif-camera

Owner: Device WG
Apache License 2.0
29 stars 37 forks source link

Version API doesn't return the SDK version #67

Closed lenny-goodell closed 2 years ago

lenny-goodell commented 2 years ago

🐞 Bug Report

Affected Services [REQUIRED]

Version API

Is this a regression?

No

Description and Minimal Reproduction [REQUIRED]

Version API doesn't return the SDK version. Sample responses:

{
    "apiVersion": "v2",
    "version": "0.0.0",
    "serviceName": "device-onvif-camera",
    "sdk_version": "0.0.0"
}

The makefile here is missing the setting of the SDK version https://github.com/edgexfoundry/device-onvif-camera/blob/main/Makefile#L22-L23 That is done here properly: https://github.com/edgexfoundry/device-rfid-llrp-go/blob/main/Makefile#L21-L23

Note this looks to be an issue will many or all the Go Devices and App services

🌍 Your Environment

Deployment Environment:

EdgeX Version [REQUIRED]:

Anything else relevant?

lenny-goodell commented 2 years ago

@weichou1229 , this is a better example of what should be in the makefile. https://github.com/edgexfoundry/device-rfid-llrp-go/blob/main/Makefile#L21-L23 I update the description with this link.