ethan256 commented 2 months ago

PR Checklist

If your build fails due to your commit message not passing the build checks, please review the guidelines here.

Please check if your PR fulfills the following requirements:

[x] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[x] I am not introducing a new dependency (add notes below if you are)
[ ] I have added unit tests for the new feature or bug fix (if not, why?)
[ ] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[ ] I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

jiekechoo commented 2 months ago

@ethan256 You should Sign-Off the commit. Just use the command: git commit -s -m "comments"

jiekechoo commented 2 months ago

Please rebase your commits to single one.

ethan256 commented 2 months ago

Please rebase your commits to single one.

Okay, thanks for the guidance. benchmark test result for readhandler as follow:

Listening on 0.0.0.0:48408
goos: linux
goarch: amd64
pkg: github.com/edgexfoundry/device-opc-ua/internal/driver
cpu: AMD Ryzen 7 5800H with Radeon Graphics         
Benchmark_HandleReadCommands_ReuseClient-4            1399      715975 ns/op       70625 B/op        172 allocs/op
Benchmark_HandleReadCommands_WithoutReuseClient-4     235      5325039 ns/op      566047 B/op       1224 allocs/op
PASS

edgexfoundry / device-opc-ua

feat: support reuse opcua.Client #48

PR Checklist

Testing Instructions

New Dependency Instructions (If applicable)