edgexfoundry / device-snmp-go

Owner: Device WG
Apache License 2.0
9 stars 35 forks source link

feat!: updates for common config #255

Closed lenny-goodell closed 1 year ago

lenny-goodell commented 1 year ago

BREAKING CHANGE: configuration file changed to remove common config settings

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-snmp-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

  1. run edgex non-secure stack
  2. build device service - make build
  3. run device service using config provider
  4. verify that private configuration is loaded in consul
  5. ensure that writable in the private config is modifyable - change log level and see change in the terminal

New Dependency Instructions (If applicable)