edgexfoundry / device-snmp-go

Owner: Device WG
Apache License 2.0
9 stars 35 forks source link

refactor!: Replace internal topics from config with new constants #256

Closed lenny-goodell closed 1 year ago

lenny-goodell commented 1 year ago

BREAKING CHANGE: Internal topics no longer configurable, except the base topic.

Requires https://github.com/edgexfoundry/device-snmp-go/pull/255 to be merged first

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-snmp-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

Run non-secure EdgeX stack Build and run device service locally with -cp (kill and restart for hybrid mode) Verify the log has the following start-up :

msg="Subscribing to command requests on topic: edgex/device/command/request/device-mqtt/#"
msg="Responses to command requests will be published on topic: edgex/response/device-mqtt/<requestId>"
"Subscribing to System Events on topic: edgex/system-events/core-metadata/+/+/device-mqtt/#

New Dependency Instructions (If applicable)

codecov-commenter commented 1 year ago

Codecov Report

Merging #256 (c1dd071) into main (d33e94f) will not change coverage. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@          Coverage Diff          @@
##            main    #256   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          2       2           
  Lines        200     200           
=====================================
  Misses       200     200           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.