Closed jinlinGuan closed 1 year ago
Merging #214 (171ca04) into main (6092c90) will not change coverage. The diff coverage is
100.00%
.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@ Coverage Diff @@
## main #214 +/- ##
=====================================
Coverage 3.05% 3.05%
=====================================
Files 6 6
Lines 687 687
=====================================
Hits 21 21
Misses 666 666
Impacted Files | Coverage Δ | |
---|---|---|
internal/driver/ffmpeg.go | 16.50% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@cloudxxx8 , FYI, we had been holding back on the newer versions of this module due to issues. @ajcasagrande thoughts on using this version?
sorry, I didn't realize it. I thought it was hold due to the CI validation error, and Ginny just solved it. the upgrade of this module resolved some bugs, especially about the memory leak. may we list the problem we encountered and we can open issues to the module and decide whether we want to revert this PR?
update go4vl format constants
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
New Dependency Instructions (If applicable)