feat: extend discovery for realsense cameras

ChristianDarr-personal commented 1 year ago

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[x] I am not introducing a new dependency (add notes below if you are)
[x] I have added unit tests for the new feature or bug fix (if not, why?)
[x] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[ ] I have opened a PR for the related docs change (if not, why?)

Testing Instructions

Make sure a realsense camera is plugged into your device.
Use v4l2-ctl --list-devices to check that the device is recognized by your system and to check the paths of the device.
Build the usb device service using make docker.
Run the edgex core services along with the device service.
Check the discovered devices (http://0.0.0.0:59881/api/v3/device/service/name/device-usb-camera), make sure that the paths match. Note that only the 1sat, 3rd and 5th paths are saved in the device, as these are the only streaming paths.
Test for rediscovery by deleting the device or restarting the service, etc.
Make sure the paths are updated if ports are changed.

New Dependency Instructions (If applicable)

codecov-commenter commented 1 year ago

Codecov Report

Merging #262 (c54c24d) into main (c5a4cd9) will increase coverage by 2.04%. The diff coverage is 13.86%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff            @@
##            main    #262      +/-   ##
========================================
+ Coverage   2.38%   4.43%   +2.04%     
========================================
  Files          8       8              
  Lines        879     925      +46     
========================================
+ Hits          21      41      +20     
- Misses       858     883      +25     
- Partials       0       1       +1

Impacted Files	Coverage Δ
internal/driver/device.go	`11.42% <ø> (ø)`
internal/driver/routes.go	`0.00% <0.00%> (ø)`
internal/driver/driver.go	`3.48% <14.00%> (+3.48%)`	:arrow_up:

lenny-goodell commented 1 year ago

A couple of attributions are missing in attribution.txt, that file needs to be updated.

Are these adding new dependencies that are not used else where in EdgeX? If so please see https://wiki.edgexfoundry.org/display/FA/Vetting+Process+for+3rd+Party+Dependencies

lenny-goodell commented 1 year ago

@ChristianDarr-personal , your last commit is fail Semantic PR. Amend the commit to fix spelling.

presatish commented 1 year ago

A couple of attributions are missing in attribution.txt, that file needs to be updated.

Are these adding new dependencies that are not used else where in EdgeX? If so please see https://wiki.edgexfoundry.org/display/FA/Vetting+Process+for+3rd+Party+Dependencies

These are indirect dependencies, so do we still need to do what you have suggested?

lenny-goodell commented 1 year ago

These are indirect dependencies, so do we still need to do what you have suggested?

Nope, just on the direct dependencies.

edgexfoundry / device-usb-camera