refactor: use PatchDevice calls instead of UpdateDevice - Githubissues

edgexfoundry / device-usb-camera

Owner: Device WG

Apache License 2.0

12 stars 28 forks source link

refactor: use PatchDevice calls instead of UpdateDevice #267

Closed ajcasagrande closed 1 year ago

ajcasagrande commented 1 year ago

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

[X] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[X] I am not introducing a new dependency (add notes below if you are)
[X] I have added unit tests for the new feature or bug fix (if not, why?)
[X] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[N/A] I have opened a PR for the related docs change (if not, why?)

Testing Instructions

Run device service as normal and add usb cameras
Change the /dev/videoX order of cameras by unplugging re-plugging (may require multiple devices)
Re-run discovery, or RefreshExistingDevicePaths
Ensure updated device paths are present in core-metadata
Run unit tests

New Dependency Instructions (If applicable)

vyshali-chitikeshi commented 1 year ago

Verified that camera device paths updated in metadata after unplugging and re plugging to different USB ports. Tested with multiple USB cameras and tried multiple times changing ports. Tested using get all cameras API command. also verified that device paths in metadata matches with v412-ctl command.