Closed marcpfuller closed 1 year ago
Merging #268 (e5325cd) into main (040a5a6) will decrease coverage by
0.12%
. The diff coverage is0.00%
.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@ Coverage Diff @@
## main #268 +/- ##
========================================
- Coverage 4.21% 4.10% -0.12%
========================================
Files 8 8
Lines 1067 1096 +29
========================================
Hits 45 45
- Misses 1022 1051 +29
Files Changed | Coverage Δ | |
---|---|---|
internal/driver/driver.go | 3.62% <0.00%> (-0.17%) |
:arrow_down: |
Validation looks good both in secure and non-secure mode deployments. Below are more details
PR name should be updated. this is a feat
. Also the current functionality is that it is enabled, so something like this:
feat: ability to disable RTSP server on startup via configuration
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
make test
make run no-secty
make build
New Dependency Instructions (If applicable)