edgexfoundry / device-usb-camera

Owner: Device WG
Apache License 2.0
12 stars 28 forks source link

feat: implement get/set pixel format commands. #269

Closed presatish closed 1 year ago

presatish commented 1 year ago

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

  1. Build docker image using make docker and deploy all edgex core services along with the usb service.
  2. Executing get PixelFormat command for a valid camera with a valid path index should give valid result with height, width, pixelFormat and other parameters.
  3. Invalid camera or path index (not video streaming path) should give error.
  4. Executing set PixelFormat command with valid parameters (height, width and pixelFormat) should be successful (200 status code). Postman collection can be referred for example. Execute get command to validate new parameters have been set.
  5. Invalid values should give errors.

New Dependency Instructions (If applicable)

codecov-commenter commented 1 year ago

Codecov Report

Merging #269 (0d42582) into main (b4dc3cb) will decrease coverage by 0.40%. The diff coverage is 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff            @@
##            main    #269      +/-   ##
========================================
- Coverage   5.69%   5.29%   -0.40%     
========================================
  Files          8       8              
  Lines       1089    1171      +82     
========================================
  Hits          62      62              
- Misses      1027    1109      +82     
Files Changed Coverage Δ
internal/driver/device.go 2.98% <0.00%> (-3.17%) :arrow_down:
internal/driver/driver.go 3.68% <0.00%> (-0.08%) :arrow_down:
internal/driver/metadata.go 0.00% <ø> (ø)