edgexfoundry / device-usb-camera

Owner: Device WG
Apache License 2.0
12 stars 28 forks source link

fix: rtsp auth server router not initialized properly #279

Closed ajcasagrande closed 1 year ago

ajcasagrande commented 1 year ago

and revert autoStreaming to false to maintain backwards compatibility

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

Run device-usb service as normal Make sure to use dockerized rtsp-server for auth config Post rtsp credentials to /secret call startstreaming api expect success

New Dependency Instructions (If applicable)

codecov-commenter commented 1 year ago

Codecov Report

Merging #279 (b4f0762) into main (81f7519) will increase coverage by 0.00%. The diff coverage is 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@          Coverage Diff          @@
##            main    #279   +/-   ##
=====================================
  Coverage   4.82%   4.83%           
=====================================
  Files          8       8           
  Lines       1284    1283    -1     
=====================================
  Hits          62      62           
+ Misses      1222    1221    -1     
Files Changed Coverage Δ
internal/driver/driver.go 3.31% <0.00%> (+<0.01%) :arrow_up: