Closed presatish closed 1 year ago
Merging #290 (18a7ff3) into main (608e40c) will decrease coverage by
0.05%
. The diff coverage is0.00%
.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@ Coverage Diff @@
## main #290 +/- ##
========================================
- Coverage 4.79% 4.74% -0.05%
========================================
Files 8 8
Lines 1293 1306 +13
========================================
Hits 62 62
- Misses 1231 1244 +13
Files Changed | Coverage Δ | |
---|---|---|
internal/driver/device.go | 2.83% <ø> (ø) |
|
internal/driver/driver.go | 3.21% <0.00%> (-0.06%) |
:arrow_down: |
internal/driver/helper.go | 80.95% <0.00%> (ø) |
Though its already merged into main, I did validaiton to ensure end-to-end testing (discovering usb cameras, adding them egex metadata and rest-api's) works correctly both with 'path' and 'paths' fields and it looks good. Validated with below combinations of code:
attaced scrresnhots for refecne. latest_edgex_and_3.0_usb_device_usb.txt 3.0_edgex_and_latest_usb_device_path.txt 3.0_edgex_and_3.0_usb_device_path.txt latest_edgex_and_latest_usb_device_path.txt
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
Path
as one of the protocol properties which is a string.Path
changes toPaths
which is an array of string.New Dependency Instructions (If applicable)