edgexfoundry / device-usb-camera

Owner: Device WG
Apache License 2.0
12 stars 28 forks source link

fix: StreamURI values not parsed in external rtsp mode #295

Closed ajcasagrande closed 1 year ago

ajcasagrande commented 1 year ago

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

Get code from this pr branch & latest edgex compose main branch

Go to device usb service cmd/res folder, and update configuation.yaml file with below settings RtspServerMode set to "external" RtspServerHostName set to remote ip address of system where rtsp server running

Build usb docker image locally with updated configuration file

Go to edgex compose/compose builder, and update add-device-usb-camera.yaml file to use local usb image

from compose builder, run 'make run no-secty ds-usb-camera' - this wills start edgex services and device usb services, also discovers and adds usb cameras to edgex

Execute some generic api like camera info, ensure camera is accessible and it works correctly

Execute ger stream uri, API Expected behavior: Should give rtsp stream uri with remote ip

New Dependency Instructions (If applicable)

Closes #288

codecov-commenter commented 1 year ago

Codecov Report

Merging #295 (f635203) into main (b907ae2) will not change coverage. The diff coverage is 0.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@          Coverage Diff          @@
##            main    #295   +/-   ##
=====================================
  Coverage   4.75%   4.75%           
=====================================
  Files          8       8           
  Lines       1305    1305           
=====================================
  Hits          62      62           
  Misses      1243    1243           
Files Changed Coverage Δ
internal/driver/driver.go 3.21% <0.00%> (ø)
vyshali-chitikeshi commented 1 year ago

Validation looks good. Get stream URI gives ip address of RTSP server address as expected. Find attached screenshot. Screenshot from 2023-09-26 18-30-26