edgexfoundry / edgex-compose

EdgeX Foundry Docker Compose release compose files and tools for building EdgeX compose files
Apache License 2.0
82 stars 119 forks source link

refactor: Override pre-defined profile and devices on device-services #344

Closed cherrycl closed 1 year ago

cherrycl commented 1 year ago

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-compose/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

cloudxxx8 commented 1 year ago

can't --configDir flag work anymore?

cherrycl commented 1 year ago

It didn't work for virtual, but still works for modbus.

cloudxxx8 commented 1 year ago

instead of using environment variable, we should diagnose how to fix the flag please open an issue in device-virtual

cherrycl commented 1 year ago

Update TAF script instead. edgex-taf #779