edgexfoundry / edgex-compose

EdgeX Foundry Docker Compose release compose files and tools for building EdgeX compose files
Apache License 2.0
81 stars 115 forks source link

feat: Add common environment overrides to Common Config service #352

Closed lenny-goodell closed 1 year ago

lenny-goodell commented 1 year ago

closes #351

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-compose/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

lenny-goodell commented 1 year ago

should we remove common.env?

Not yet. There will be a follow-up PR to do some clean-up once the edgex-go PRs are merged.

can we use use one volume for /kuiper/ instead of so many volumes?

We can look at that, but out of scope for this PR