Closed lenny-goodell closed 1 year ago
If I wanted to compare the generated docker-compose files for this vs previous version, what differences should I expect to see?
If I wanted to compare the generated docker-compose files for this vs previous version, what differences should I expect to see?
The diffs for the generated are in this PR. You will see many env overrides removed since they are now only needed on Common Config
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-compose/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
Pull all latest images Run the following commands and verify services bootstrap successfully and are using the appropriate MessageBus
Secure Mode
make run ds-virtual ds-rest asc-sample
Connected to redis Message Bus @ redis://edgex-redis:6379 with AuthMode='usernamepassword'
make clean
make run ds-virtual ds-rest asc-sample mqtt-bus
Connected to mqtt Message Bus @ tcp://edgex-mqtt-broker:1883 with AuthMode='usernamepassword'
make clean
Non-Secure Mode
make run ds-virtual ds-rest asc-sample no-secty
Connected to redis Message Bus @ redis://edgex-redis:6379 with AuthMode='usernamepassword'
make clean
make run ds-virtual ds-rest asc-sample mqtt-bus no-secty
Connected to mqtt Message Bus @ tcp://edgex-mqtt-broker:1883 with AuthMode='none'
make clean