edgexfoundry / edgex-compose

EdgeX Foundry Docker Compose release compose files and tools for building EdgeX compose files
Apache License 2.0
81 stars 115 forks source link

refactor: Rework env overrides for common config in place #355

Closed lenny-goodell closed 1 year ago

lenny-goodell commented 1 year ago

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-compose/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

Pull all latest images Run the following commands and verify services bootstrap successfully and are using the appropriate MessageBus

Secure Mode

bnevis-i commented 1 year ago

If I wanted to compare the generated docker-compose files for this vs previous version, what differences should I expect to see?

lenny-goodell commented 1 year ago

If I wanted to compare the generated docker-compose files for this vs previous version, what differences should I expect to see?

The diffs for the generated are in this PR. You will see many env overrides removed since they are now only needed on Common Config