edgexfoundry / edgex-compose

EdgeX Foundry Docker Compose release compose files and tools for building EdgeX compose files
Apache License 2.0
81 stars 115 forks source link

refactor!: Rework service names to conform to consistent naming #361

Closed lenny-goodell closed 1 year ago

lenny-goodell commented 1 year ago

BREAKING CHANGE: Many sevice names have changed in order to conform with core-, support-, app- and device- naming standard. Impact should be minimal unless scripts have references to the old service names, rather than container names. Container name havent chnaged except for app-functional-tests' which is now edgex-app-functional-tests

closes #231 Signed-off-by: Leonard Goodell leonard.goodell@intel.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-compose/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

run make run ds-virtual Verify all service bootstrap and data is flowing from Device Virtual to App Rules Engine

lenny-goodell commented 1 year ago

@cherrycl , based on my searching of the TAF repo, this will not impact any tests except maybe backward compatible, which is not in scope for this release. I didn't find any scripts referencing the service names except for get-compose-file-backward.sh

bnevis-i commented 1 year ago

Testing affected by https://github.com/edgexfoundry/edgex-go/pull/4492, but after fix, nothing major seems to be broken.