fix: added missing delayed started spiffe volume for support services

jim-wang-intel commented 1 year ago

Updated Makefile to run delayed-started generation script for support services to make sure these serivces are delayed-startable

Fixes: #364

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-compose/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

[x ] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
[x ] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
[ ] I have opened a PR for the related docs change (if not, why?)

docker build the latest edgex-go and ensure the fix in this PR is in there: https://github.com/edgexfoundry/edgex-go/pull/4509
use compose_builder to run it with delay-started mode: make run dev delayed-start ds-virtual ds-modbus
wait for a few minutes to let everything start up and settle down
verify that both support-notifications and support-scheduler are now received tokens from spiffe token provider

jim-wang-intel commented 1 year ago

@cherrycl please verify on your side too to make sure this works for your testing environment, thanks!

bnevis-i commented 1 year ago

Note that https://github.com/edgexfoundry/edgex-go/pull/4509 needs to be merged before this fix will work.

bnevis-i commented 1 year ago

Need to run make build

Let's get this added to the PR checklist. I am tired of seeing you type it.

jim-wang-intel commented 1 year ago

Need to run make build

no changes, no compose file changes

lenny-goodell commented 1 year ago

no changes, no compose file changes

Then how is this addressing the issue if no compose file changes?

bnevis-i commented 1 year ago

no changes, no compose file changes

Then how is this addressing the issue if no compose file changes?

delayed-start is a nonstandard option -- it isn't enabled in the pre-built docker-compose files.

lenny-goodell commented 1 year ago

delayed-start is a nonstandard option -- it isn't enabled in the pre-built docker-compose files.

Ohh Yea, for got... ;-)

jim-wang-intel commented 1 year ago

Need to run make build

Let's get this added to the PR checklist. I am tired of seeing you type it.

Bryon: create a make build robot when any PR check in :-)