edgexfoundry / edgex-compose

EdgeX Foundry Docker Compose release compose files and tools for building EdgeX compose files
Apache License 2.0
81 stars 115 forks source link

fix: Repair startup arguments for device-bacnet in secure mode #374

Closed bnevis-i closed 1 year ago

bnevis-i commented 1 year ago

device-bacnet container does not contain a startup.sh. Replace with appropriate command based on what is in the default ENTRYPOINT and CMD for no-security container.

Modify gen_secure_compose_ext.sh script to use comma delimeter in case executable to be launched uses slash as part of its path.

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

make run ds-bacnet

Note that docker logs edgex-device-bacnet will terminate with

level=INFO ts=2023-04-18T20:53:15Z app=device-coap msg="Uploading configuration to registry."
level=ERROR ts=2023-04-18T20:53:15Z app=device-coap msg="Unable to upload config: HTTP 409 Conflict"
Error: 17: HTTP 409 Conflict

However, the current scenario is that the container does not run at all, so this is an improvement.

jim-wang-intel commented 1 year ago

@bnevis-i will make build changes anything in compose files? just want to confirm

bnevis-i commented 1 year ago

@bnevis-i will make build changes anything in compose files? just want to confirm

Make build results in no changes to the generated compose files.