edgexfoundry / edgex-compose

EdgeX Foundry Docker Compose release compose files and tools for building EdgeX compose files
Apache License 2.0
81 stars 115 forks source link

feat: support mediamtx rtsp server #379

Closed ajcasagrande closed 8 months ago

ajcasagrande commented 1 year ago

This supports splitting out the mediamtx rtsp-server from the device-usb-camera service such that it can be made optional, as well as allows the end user to control the rtsp-server configuration in a more streamlined manner.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-compose/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

make run rtsp-server ds-usb-camera

execute StartStreaming apis of device usb and verify streaming works

lenny-goodell commented 11 months ago

@ajcasagrande , are you still wanting to take this approach. I am good with it as long we don't introduce backward breaking changes.

ajcasagrande commented 11 months ago

@ajcasagrande , are you still wanting to take this approach. I am good with it as long we don't introduce backward breaking changes.

Yes, this would be my preferred approach in a docker environment as it gives full control of the rtsp-server.

lenny-goodell commented 10 months ago

Yes, this would be my preferred approach in a docker environment as it gives full control of the rtsp-server.

OK, please update the PR and take out of draft and we can get it in.

bnevis-i commented 9 months ago

@ajcasagrande This request is stale.

lenny-goodell commented 8 months ago

closing due to inaction. PLease reopen if needed.