edgexfoundry / edgex-compose

EdgeX Foundry Docker Compose release compose files and tools for building EdgeX compose files
Apache License 2.0
82 stars 119 forks source link

build: Unpin patch on 3rd party versions and use latest #390

Closed lenny-goodell closed 1 year ago

lenny-goodell commented 1 year ago

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-compose/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

run make pull from top folder run make run from top folder Verify all service bootstrapped Change app-rules-engine logging to DEBUG in Consul Verify logs show events flowing Test version/ping end point via API gate way. Verify UI is seeing the following

lenny-goodell commented 1 year ago

Reset

MOSQUITTO_VERSION=2.0
NGINX_VERSION=1.25-alpine-slim

Fixed

lenny-goodell commented 1 year ago

recheck

lenny-goodell commented 1 year ago

@cherrycl , smoke tests failing to run on this PR. Any ideas? THX!

cherrycl commented 1 year ago

@lenny-intel Would you please squash and rebase the commits? TAF can't get correct SHA1 value if PR contains multiple commits.

lenny-goodell commented 1 year ago

@cherrycl , now all TAF tests are failing. I have tried amending commit and force pushing and even tried recreating the PR (with same commit on new branch)

cloudxxx8 commented 1 year ago

@lenny-intel we will check it by Monday. Maybe there is something wrong from by taf-common upgrade.

cherrycl commented 1 year ago

recheck

cherrycl commented 1 year ago

@lenny-intel Smoke-test job always got incorrect SHA1. Not sure why, but I found this PR's commit seems not synchronize with main branch, could you merge the main branch's commit and try to run the test again?

cloudxxx8 commented 1 year ago

recheck

lenny-goodell commented 1 year ago

@lenny-intel Smoke-test job always got incorrect SHA1. Not sure why, but I found this PR's commit seems not synchronize with main branch, could you merge the main branch's commit and try to run the test again?

@cherrycl , Rebasing fix it. THX!