edgexfoundry / edgex-compose

EdgeX Foundry Docker Compose release compose files and tools for building EdgeX compose files
Apache License 2.0
81 stars 115 forks source link

fix: Change service key from device-bacnet to device-bacnet-ip #398

Closed FelixTing closed 11 months ago

FelixTing commented 11 months ago

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-compose/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

fix: #397

Testing Instructions

make run ds-bacnet-ip Verify if the BACnet device service runs normally.

cloudxxx8 commented 11 months ago

LGTM, please also make same change on the minnesota branch

@lenny-intel the current v3.0 bacnet doesn't work anyway. may we fix it when we have 3.0.1 image?

lenny-goodell commented 11 months ago

@FelixTing , please make sure the generated compose has the correct device-bacnet-ip name in the volume mount for the vault token

FelixTing commented 11 months ago

@FelixTing , please make sure the generated compose has the correct device-bacnet-ip name in the volume mount for the vault token

Verified. There is no problem with the volume mount.

FelixTing commented 11 months ago

recheck

FelixTing commented 11 months ago

rebased