fix: camera mgmt docker build, secret names, and go mods - Githubissues

edgexfoundry / edgex-examples

Apache License 2.0

51 stars 52 forks source link

fix: camera mgmt docker build, secret names, and go mods #229

Closed ajcasagrande closed 1 year ago

ajcasagrande commented 1 year ago

Fixed the docker build for Camera Management App and make it work with docker compose.
Fixed the naming inconsistencies with secrets in the yaml file and code. Now also matches rtspauth from the device-usb-camera service.
Removed errors package from go.mod, to use EdgeX errors package, to match the device services.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-examples/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

[N/A] I have added unit tests for the new feature or bug fix (if not, why?)
[X] I have fully tested (add details below) this the new feature or bug fix (if not, why?)

Testing Instructions

vyshali-chitikeshi commented 1 year ago

Valediction looks good in non-secure mode. Tested with ONVIF and USB cameras. Default pipelines starts automatially, manual start/stop of pipeline works, streaming of events works for both ONVIF and USB cameras. On ONVIF also verified PTZ operations. It works correctly