fix: fixing remote spire agent docker file to resolve build issues

edgexfoundry / edgex-examples

Apache License 2.0

51 stars 52 forks source link

fix: fixing remote spire agent docker file to resolve build issues #235

Closed vyshali-chitikeshi closed 10 months ago

vyshali-chitikeshi commented 10 months ago

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-examples/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

[x] I have added unit tests for the new feature or bug fix (if not, why?)
[x] I have fully tested (add details below) this the new feature or bug fix (if not, why?)

Testing Instructions

vyshali-chitikeshi commented 10 months ago

Updated docker file as per review comments, validated with device usb service. able to build remote spire agent successfully and device usb service started successfully on remote node

vyshali-chitikeshi commented 10 months ago

@bnevis-i without arg for Builder base, it builds successfully and device service started. So i updated my commit according to Lenny's comments.

bnevis-i commented 10 months ago

@bnevis-i without arg for Builder base, it builds successfully and device service started. So i updated my commit according to Lenny's comments.

Ok. If it fails in CI we can always put it back.

lenny-goodell commented 10 months ago

Ok. If it fails in CI we can always put it back.

No CI on this repo... ;-)