ernestojeda
commented
1 year ago LGTM, makes sense where you put it. Do we want to control the vanity flag from the release.yml at all? As it is now, it looks like it will create a vanity tag for every release of every artifact. (Which I think is OK)
Ahh, that would probably be a good idea. I will add a new field into the yaml.
Functional Test: Release v5.1.4
https://jenkins.edgexfoundry.org/job/edgexfoundry/job/cd-management/job/PR-359/20/console
Functional Test: Release v5.1.5
https://jenkins.edgexfoundry.org/job/edgexfoundry/job/cd-management/job/PR-359/21/console
In both functional tests the v5.1 tag was created and pointed to the released version.
PR Checklist
Please check if your PR fulfills the following requirements:
[x] The commit message follows our guidelines: https://github.com/edgexfoundry/ci-management/blob/master/.github/CONTRIBUTING.md
[x] Tests for the changes have been added (for bug fixes / features)
[x] Added labels
PR Type
What kind of change does this PR introduce?
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:
Issue Number: #435
Sandbox Testing
Test Links :
Are there any new imports or modules? If so, what are they used for and why?
Are there any specific instructions or things that should be known prior to reviewing?
Other information