edgexfoundry / edgex-helm

Owner: Core WG
Apache License 2.0
4 stars 7 forks source link

fix: Fix pathType warnings on ingress resources #23

Closed bnevis-i closed 1 year ago

bnevis-i commented 1 year ago

Closes #21

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

Install helm chart as usual

jim-wang-intel commented 1 year ago

don't remember what version of Kubernetes we required, only version 1.18 or above has this pathType feature

https://docs.nginx.com/nginx-ingress-controller/configuration/ingress-resources/basic-configuration/ in section New Features Available in Kubernetes 1.18 and Above

bnevis-i commented 1 year ago

don't remember what version of Kubernetes we required, only version 1.18 or above has this pathType feature

https://docs.nginx.com/nginx-ingress-controller/configuration/ingress-resources/basic-configuration/ in section New Features Available in Kubernetes 1.18 and Above

https://kubernetes.io/releases/

The Kubernetes project maintains release branches for the most recent three minor releases (1.28, 1.27, 1.26). Kubernetes 1.19 and newer receive approximately 1 year of patch support. Kubernetes 1.18 and older received approximately 9 months of patch support.

1.17 reached end of support on 25 Dec 2020. (https://endoflife.date/kubernetes)

jim-wang-intel commented 1 year ago

don't remember what version of Kubernetes we required, only version 1.18 or above has this pathType feature

https://docs.nginx.com/nginx-ingress-controller/configuration/ingress-resources/basic-configuration/ in section New Features Available in Kubernetes 1.18 and Above

https://kubernetes.io/releases/

The Kubernetes project maintains release branches for the most recent three minor releases (1.28, 1.27, 1.26). Kubernetes 1.19 and newer receive approximately 1 year of patch support. Kubernetes 1.18 and older received approximately 9 months of patch support.

1.17 reached end of support on 25 Dec 2020. (https://endoflife.date/kubernetes)

ok, it is interesting in that ngnix docs, it says The ImplementationSpecific pathType is treated as equivilent to Prefix pathType, with the exception that when this pathType is configured, the path field in spec.rules[].http.paths[] is not mandatory. path defaults to / if not set but the pathType is set to ImplementationSpecific.

bnevis-i commented 1 year ago

ok, it is interesting in that ngnix docs, it says The ImplementationSpecific pathType is treated as equivilent to Prefix pathType, with the exception that when this pathType is configured, the path field in spec.rules[].http.paths[] is not mandatory. path defaults to / if not set but the pathType is set to ImplementationSpecific.

I can't make sense of that, but the regexp is needed for the rewrite rule and when I use ImplementationSpecific the warning goes away :-)

jim-wang-intel commented 1 year ago

ok, it is interesting in that ngnix docs, it says The ImplementationSpecific pathType is treated as equivilent to Prefix pathType, with the exception that when this pathType is configured, the path field in spec.rules[].http.paths[] is not mandatory. path defaults to / if not set but the pathType is set to ImplementationSpecific.

I can't make sense of that, but the regexp is needed for the rewrite rule and when I use ImplementationSpecific the warning goes away :-)

probably that's some implementation details inside helm or kube which we don't know...