search

edgexfoundry / edgex-ui-go

Owner: Core/Support WG
Apache License 2.0
99 stars 101 forks source link

Add Device Protocol list in UI #373

Open jlikeme opened 3 years ago

jlikeme commented 3 years ago

Add Device Protocol list in UI, because there will have two or more device protocols in some devices.

badboy-huaqiao commented 3 years ago

@gao270615179 Good Catch! šŸ‘, that's also our plan not long ago, but due to some irresistible factors we would to do that next version.

But if you have finished that section, we will be very glad to see that your code is committed here.

badboy-huaqiao commented 2 years ago

After the deeper research and discussion with core team, it doesn't looks like so necessary, what the basis of the conclusion is that which one should be used for device to create the connection at a time. for example, the modbus service supports both RTU and TCP, but only one of them will be used at a time. if thereā€˜s dynamic switching needed, customize your own application.

maybe it should be needed in the future, but now keep that unchanged.

ajcasagrande commented 2 years ago

This feature is useful for the device-onvif-camera service, as right now we utilize the ProtocolProperties as a way to store custom metadata about a device. The problem is that newly discovered devices get both the Onvif and CustomMetadata protocols added, but in the UI only the CustomMetadata shows up:

Screenshot from 2022-07-05 11-22-00

Screenshot from 2022-07-05 11-22-15

badboy-huaqiao commented 2 years ago

@ajcasagrande that would be great to support multiple device protocols, if we're planing to add new protocol template for device-onvif-camera service (see #531), this feature is required, assign it to me, I will update that.

ajcasagrande commented 2 years ago

@badboy-huaqiao This isn't required for #531 , though it would be nice. The device service will end up adding the missing CustomMetadata protocol I believe. This mostly effects the viewing and editing of existing devices.