edgexfoundry / go-mod-bootstrap

go-mod-bootstrap
Apache License 2.0
15 stars 55 forks source link

feat: use zero trust dialer again #735

Closed dovholuknf closed 1 month ago

dovholuknf commented 1 month ago

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

New Dependency Instructions (If applicable)

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.97%. Comparing base (b2edd5a) to head (aa37b36).

Files Patch % Lines
bootstrap/registration/registry.go 0.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #735 +/- ## ========================================== - Coverage 54.99% 54.97% -0.03% ========================================== Files 32 32 Lines 2711 2712 +1 ========================================== Hits 1491 1491 - Misses 1118 1119 +1 Partials 102 102 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dovholuknf commented 1 month ago

@cloudxxx8 -- i removed a second location where the bypass was put in place and allowed it only for "keeper"

cloudxxx8 commented 1 month ago

close this PR due to the byPass code is removed from https://github.com/edgexfoundry/go-mod-bootstrap/pull/736