edgexfoundry / go-mod-bootstrap

go-mod-bootstrap
Apache License 2.0
16 stars 55 forks source link

fix: Fixed regression bug of keeper clients with zero trust #736

Closed jackchenjc closed 3 months ago

jackchenjc commented 3 months ago

fixes: #734

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-bootstrap/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

New Dependency Instructions (If applicable)

jackchenjc commented 3 months ago

Hi @dovholuknf, @cloudxxx8 ,

This commit should fix the regression bug and make Core-Keeper clients work fine with zero trust mode (need more tests with edgex-compose), would you please help reviewing it, thanks.

BTW, I found another error from the device-virtual while briefly testing the whole stack, would it be the regression bug as well?

level=ERROR ts=2024-07-22T12:11:19.769044503Z app=device-virtual source=logging.go:35 msg="openziti: error listing controllers, continuing with 1 default configured controller"
codecov-commenter commented 3 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 54.87%. Comparing base (b2edd5a) to head (f0f51ad).

Files Patch % Lines
bootstrap/registration/registry.go 0.00% 7 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #736 +/- ## ========================================== - Coverage 54.99% 54.87% -0.13% ========================================== Files 32 32 Lines 2711 2717 +6 ========================================== Hits 1491 1491 - Misses 1118 1124 +6 Partials 102 102 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.