edgexfoundry / go-mod-bootstrap

go-mod-bootstrap
Apache License 2.0
16 stars 55 forks source link

feat: add fallback dialing support #739

Closed dovholuknf closed 3 months ago

dovholuknf commented 3 months ago

Should core-keeper require overriding the dialer this is where/how I think it makes sense.

PR Checklist

Please check if your PR fulfills the following requirements:

codecov-commenter commented 3 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 54.95%. Comparing base (5dc0b86) to head (9f0cc45).

Files Patch % Lines
bootstrap/secret/secure.go 0.00% 7 Missing :warning:
bootstrap/secret/insecure.go 0.00% 3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #739 +/- ## ========================================== - Coverage 55.01% 54.95% -0.07% ========================================== Files 32 32 Lines 2710 2715 +5 ========================================== + Hits 1491 1492 +1 - Misses 1117 1121 +4 Partials 102 102 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.