edgexfoundry / go-mod-core-contracts

Owner: Core/Support WG
Apache License 2.0
27 stars 67 forks source link

feat: Set Default Value for AdminState and Enhancements for Cron Scheduler #916

Closed jackchenjc closed 3 months ago

jackchenjc commented 3 months ago

closes: #915

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

New Dependency Instructions (If applicable)

codecov-commenter commented 3 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 67.33%. Comparing base (e25b965) to head (83d3b8d).

Files Patch % Lines
dtos/schedulejob.go 76.92% 4 Missing and 2 partials :warning:
models/device.go 0.00% 4 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #916 +/- ## ========================================== - Coverage 67.34% 67.33% -0.02% ========================================== Files 103 104 +1 Lines 4245 4274 +29 ========================================== + Hits 2859 2878 +19 - Misses 1141 1149 +8 - Partials 245 247 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.