edgexfoundry / go-mod-core-contracts

Owner: Core/Support WG
Apache License 2.0
27 stars 67 forks source link

feat: Add more extendable fields to dtos/models for v4 #952

Closed jinlinGuan closed 1 week ago

jinlinGuan commented 1 week ago

close #951

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

Testing Instructions

New Dependency Instructions (If applicable)

codecov-commenter commented 1 week ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 20.97561% with 162 lines in your changes missing coverage. Please review.

Project coverage is 42.78%. Comparing base (d6cbbad) to head (b4b29ec).

Files with missing lines Patch % Lines
clients/interfaces/mocks/NotificationClient.go 0.00% 94 Missing :warning:
common/validator.go 0.00% 21 Missing :warning:
common/utils.go 0.00% 15 Missing :warning:
dtos/notification.go 0.00% 12 Missing :warning:
clients/http/notification.go 82.35% 3 Missing and 3 partials :warning:
dtos/deviceresource.go 0.00% 5 Missing :warning:
dtos/deviceprofile.go 40.00% 2 Missing and 1 partial :warning:
dtos/deviceservice.go 33.33% 2 Missing :warning:
dtos/requests/deviceservice.go 0.00% 1 Missing and 1 partial :warning:
dtos/requests/notification.go 84.61% 1 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #952 +/- ## ========================================== - Coverage 43.14% 42.78% -0.36% ========================================== Files 113 112 -1 Lines 6682 6813 +131 ========================================== + Hits 2883 2915 +32 - Misses 3561 3656 +95 - Partials 238 242 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: