search

edgexr / edge-cloud-platform

Apache License 2.0
1 stars 0 forks source link

Added startup FQDN/URI fields to appinst, clusterinst, and cloudlet. #347

Closed levshvarts closed 2 months ago

levshvarts commented 3 months ago

Description

In order to accomodate DNS migration for platform we needed to add immutable startup fields, which will be used to find the correct VM names, since those are derived from the FQDN names.

Added fields to clusterinst.proto, appinst.proto and cloudlet.proto to manage startup names.

Added upgrade function for etcd objects in order to set the new startup fields correctly(initially these will get set to runtime values of fqdn)

levshvarts commented 3 months ago

Looks good! Instead of "startup", can we use something that denotes that it should never change. Maybe "static" or "immutable" or "const"?

I think "startup" denotes that it's something that doesn't changes - since that's what it was at startup. Other names don't convey where this value gets set at. Do you feel another prefix is better?

gainsley commented 3 months ago

I don't know, "startup" just sounds like something that happened at startup, but everything happens at startup and doesn't speak to whether it can be modified or not. To me "startup" is kinda like "initial". I would prefer something that implies it doesn't change, same a constant.

levshvarts commented 3 months ago

changed startup to static