Closed ericnost closed 4 years ago
Check out this pull request on
Review Jupyter notebook visual diffs & provide feedback on notebooks.
Powered by ReviewNB
Thanks @Frijol ! Could you remind me how we take https://github.com/edgi-govdata-archiving/ECHO-COVID19/blob/static-html-build/ECHO_COVID19_pg_run.html and make it publicly viewable as web page?
Just prepend https://htmlpreview.github.io/? to any github-hosted HTML page!
I worry about the database not working and I was wondering if the language change could be something Leslie could look at in reformatting the charts (not sure how she's doing it!) At the very least, the text will make it clear that we mean reported violations
That said, I think you have a clear sense of where this language needs to change and where it doesn't, so I would welcome you to re-run it with those changes!
Let's go ahead with this as is for now!
@lesliealanis is manipulating the images in Paint 3D so she can make it say whatever she wants but can't do stacked bar charts. Maybe @maalvikabhat would have time to look at (a) changing language in titles/axes/legends to say "Reported Violations" and (b) create a stacked bar chart which stacks failures to report on top of known violations for CWA violations?
@Frijol - Here is the full final version of the notebook. If you could run it ASAP to build the static HTML version, that would be ideal, because then the data will match what's in the doc right now.