Closed ericnost closed 3 years ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Also pinging @Frijol since I think you mentioned interest in reviewing
Hi Eric, There is a flag that can be set to False in cell 3 so that it runs as it did in the past. I'll check it in again with the False setting, so that is what people get when they check it out or run it on colab.
read_cds_from_csv = False
On Tue, Nov 3, 2020 at 12:02 PM Eric Nost notifications@github.com wrote:
Here are the Spanish language notebooks @lesliealanis https://github.com/lesliealanis put together.
@shansen5 https://github.com/shansen5 - could you take a look? We also need to account for the fact that it's trying to pull a list of CDs from a local file. This is an issue with the recently checked-in copy of AllPrograms too. That's not good because then the public can't run the notebook.
You can view, comment on, or merge this pull request online at:
https://github.com/edgi-govdata-archiving/ECHO-Cross-Program/pull/114 Commit Summary
- spanish langauge notebook
File Changes
- A Spanish_AllPrograms.ipynb https://github.com/edgi-govdata-archiving/ECHO-Cross-Program/pull/114/files#diff-2f6aba6d662248b1467d06600196bb1b2017b46f175be2b23028c09c93535ea7 (1485)
- A Spanish_ECHO_National.ipynb https://github.com/edgi-govdata-archiving/ECHO-Cross-Program/pull/114/files#diff-89b4af9ea5d71a4bc7d0ffef371d39798183cf4debd72c4ebdcd34676fc263e6 (785)
Patch Links:
- https://github.com/edgi-govdata-archiving/ECHO-Cross-Program/pull/114.patch
https://github.com/edgi-govdata-archiving/ECHO-Cross-Program/pull/114.diff
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/edgi-govdata-archiving/ECHO-Cross-Program/pull/114, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF2XQ3IYNC7245T5CLRHQLSOBOXHANCNFSM4TJFYCZA .
Oh perfect thank you @shansen5 It might be good to un-comment out # state_cds.extend([('DE',None),('WY',None)])
so that there is an easy example to work with and run?
Here are the Spanish language notebooks @lesliealanis put together.
@shansen5 - could you take a look? We also need to account for the fact that it's trying to pull a list of CDs from a local file. This is an issue with the recently checked-in copy of AllPrograms too. That's not good because then the public can't run the notebook.