search

edgi-govdata-archiving / ECHO-Cross-Program

Jupyter Notebooks for ECHO that use data from multiple EPA programs
https://colab.research.google.com/github/edgi-govdata-archiving/ECHO-Cross-Program/blob/master/ECHO-Cross-Programs.ipynb
GNU General Public License v3.0
8 stars 5 forks source link

Strange/empty graphs for quarters out of compliance in cell #5 #133

Closed Frijol closed 2 years ago

Frijol commented 2 years ago

Notebook: https://colab.research.google.com/github/edgi-govdata-archiving/ECHO-Cross-Program/blob/main/ECHO-Cross-Programs.ipynb#scrollTo=tGG4dLXuaRLN

Empty graphs for CAA and RCRA are confusing. The top one shows two violators, but there are no quarters in violation. The second graph gives no violators and has no title (I assume it's RCRA?)

It would be better to just not show the graph if there are no quarters out of compliance.

To reproduce:

Set Zip Code 98103 and run cell 5 to chart violators.

To close:

Only display graphs in this cell for categories of regulation that have violators. Otherwise, print that there are no violators for the region in that category.

ericnost commented 2 years ago

Looks like this issue has been fixed! 🎉