search

edgi-govdata-archiving / ECHO-Cross-Program

Jupyter Notebooks for ECHO that use data from multiple EPA programs
https://colab.research.google.com/github/edgi-govdata-archiving/ECHO-Cross-Program/blob/master/ECHO-Cross-Programs.ipynb
GNU General Public License v3.0
8 stars 5 forks source link

Infer state from Zip code #134

Open Frijol opened 2 years ago

Frijol commented 2 years ago

Notebook: https://colab.research.google.com/github/edgi-govdata-archiving/ECHO-Cross-Program/blob/main/ECHO-Cross-Programs.ipynb#scrollTo=LH-8VrSTaRLN

If you are running the Notebook on a Zip code, specifying State (cell 3) is not required. However, the "state" field is used in creating graph titles. This means that it's easy to accidentally create misleading graphics, showing mislabeled/invalid locations. For example:

image

(The Zip code specified is in Washington, but Alabama is selected by default in the State dropdown, so the graph title shows an invalid location.)

There are two possible solutions:

  1. Infer the "state" field from the Zip code so that it is correct in the graphs
  2. Don't display the state when analyzing by Zip code

Option 1 seems better to me even though it adds a bit more code complexity, since it produces a more usable end result. Any opinions on that preference @ericnost @shansen5 ?

bhvya1505 commented 2 years ago

Hi, I would like to contribute and attempt to solve this issue. I am new to open source so I am not sure if you need to assign it to me or I can go ahead and fork. Can I work on it?

Frijol commented 2 years ago

Please go ahead! Let us know if you have any questions.

shansen5 commented 2 years ago

Yes @byvya1505, thank you for offering to help on this. Note that this notebook imports our ECHO_modules code, and you may need to look into that. https://github.com/edgi-govdata-archiving/ECHO_modules I haven't yet looked to see if there is a resource for mapping from zip codes to states.

Frijol commented 2 years ago

Hi @bhvya1505 are you still working on this one? Anything we can do to support?